Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebDataStreamNotAvailableNotification triggers GA4 settings fetch on dashboard when module not connected #10259

Open
1 task
aaemnnosttv opened this issue Feb 22, 2025 · 0 comments
Open
1 task

WebDataStreamNotAvailableNotification triggers GA4 settings fetch on dashboard when module not connected #10259

aaemnnosttv opened this issue Feb 22, 2025 · 0 comments
Assignees
@aaemnnosttv
Labels
Module: Analytics Google Analytics module related issues P1 Medium priority Type: Bug Something isn't working

Comments

@aaemnnosttv
Copy link
Collaborator

Bug Description

In #9291 we updated this notification to use the new Notifications API. In doing so, a small regression was introduced which causes GA4 settings to be fetched when the module isn't connected.

Steps to reproduce

  1. Connect Site Kit from a clean state with minimal setup only
  2. Observe analytics-4 settings fetch on dashboard

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry
@aaemnnosttv aaemnnosttv self-assigned this Feb 22, 2025
@aaemnnosttv aaemnnosttv added Type: Bug Something isn't working P1 Medium priority Module: Analytics Google Analytics module related issues labels Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaemnnosttv aaemnnosttv

Labels
Module: Analytics Google Analytics module related issues P1 Medium priority Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aaemnnosttv