-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any plans to add cmake support? #4
Comments
Not at this time |
Would you accept PRs for someone adding that? or just "hard no"? :) |
Autotools, please. |
It's not a hard no to CMake. We've discussed it, and would like to support it in the future. However, time is a finite resource, and nobody is scheduled to work on it. I've told @ckennelly that I'll look into it in the coming weeks, but I have a lot on my plate already. We likely want to model the behavior of Abseil in it's handling of CMake and Bazel, so PR's that implement something different would not be accepted at this time. Supporting autotools is a non-goal of the project. |
When you say:
What are you referring to specifically then? I will probably write some CMake for tcmalloc soon in any case - so if I can model it "right" from the beginning I am happy to do so. |
Compile failed. All day. I want to use Cmake. |
Some example of integration of tcmalloc to a project with CMake build system can be found here: ClickHouse/ClickHouse#11590 |
+1 to this. Please publish build instructions without Bazel, using cmake or just GNU make. |
Hi, I have started to play here:
Anybody is welcome to use the files make suggestions and create PRs. My hope is that the branch will eventually be merged into this repository. My aim is not to replace |
Hello @tru |
We dropped it and went with rpmalloc instead. |
a cmake PR has been made that looks promising. would be great to have a tcmalloc official release once that gets in and the core code is at a known stable point. gperftools follows this project too slowly |
I assume this refers to #104, just to note it to make it easier to find. Cmake support would be in line with https://opensource.google/documentation/policies/cplusplus-support. |
Hi @tru |
|
UPDATE: |
See title.
bazel is not really widely used.
The text was updated successfully, but these errors were encountered: