Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans to add cmake support? #4

Open
StephanDollberg opened this issue Feb 12, 2020 · 16 comments
Open

Any plans to add cmake support? #4

StephanDollberg opened this issue Feb 12, 2020 · 16 comments

Comments

@StephanDollberg
Copy link

See title.

bazel is not really widely used.

@ckennelly
Copy link
Collaborator

Not at this time

@JonKohler
Copy link

Would you accept PRs for someone adding that? or just "hard no"? :)

@jedisct1
Copy link

Autotools, please.

@EricWF
Copy link

EricWF commented Feb 18, 2020

It's not a hard no to CMake. We've discussed it, and would like to support it in the future. However, time is a finite resource, and nobody is scheduled to work on it. I've told @ckennelly that I'll look into it in the coming weeks, but I have a lot on my plate already.

We likely want to model the behavior of Abseil in it's handling of CMake and Bazel, so PR's that implement something different would not be accepted at this time.

Supporting autotools is a non-goal of the project.

@tru
Copy link

tru commented Mar 4, 2020

When you say:

We likely want to model the behavior of Abseil in it's handling of CMake and Bazel, so PR's that implement something different would not be accepted at this time.

What are you referring to specifically then?

I will probably write some CMake for tcmalloc soon in any case - so if I can model it "right" from the beginning I am happy to do so.

@AsteriskZuo
Copy link

Compile failed. All day. I want to use Cmake.

@alexey-milovidov
Copy link

Some example of integration of tcmalloc to a project with CMake build system can be found here: ClickHouse/ClickHouse#11590

@ipizhenko
Copy link

ipizhenko commented Mar 4, 2021

+1 to this. Please publish build instructions without Bazel, using cmake or just GNU make.

@ObiWahn
Copy link

ObiWahn commented Mar 13, 2021

Hi, I have started to play here:

https://github.com/extcpp/tcmalloc/tree/cmake

Anybody is welcome to use the files make suggestions and create PRs. My hope is that the branch will eventually be merged into this repository. My aim is not to replace Bazel but to make tcmalloc usable for projects that use CMake and want to build tcmalloc from source. Therefore I personally neglect (tests - in the beginning) installation and especially packaging.

@Dan-Do
Copy link

Dan-Do commented Oct 25, 2021

When you say:

We likely want to model the behavior of Abseil in it's handling of CMake and Bazel, so PR's that implement something different would not be accepted at this time.

What are you referring to specifically then?

I will probably write some CMake for tcmalloc soon in any case - so if I can model it "right" from the beginning I am happy to do so.

Hello @tru
How is the status of making cmake build?

@tru
Copy link

tru commented Oct 25, 2021

We dropped it and went with rpmalloc instead.

@todd-richmond
Copy link

a cmake PR has been made that looks promising. would be great to have a tcmalloc official release once that gets in and the core code is at a known stable point. gperftools follows this project too slowly

@matta
Copy link

matta commented Sep 10, 2022

a cmake PR has been made that looks promising.

I assume this refers to #104, just to note it to make it easier to find. Cmake support would be in line with https://opensource.google/documentation/policies/cplusplus-support.

This was referenced Sep 11, 2022
@patty641
Copy link

Hi @tru
Are there any updates regarding the status of Cmake Build?

@tru
Copy link

tru commented Mar 13, 2023

Hi @tru Are there any updates regarding the status of Cmake Build?

#4 (comment)

@ObiWahn
Copy link

ObiWahn commented Mar 13, 2023

cryptopp has a nice solution. I could create something similar to https://github.com/noloader/cryptopp-cmake. It would be nice if there was somebody to test and and give feedback.

UPDATE:
I have started here: https://github.com/ObiWahn/tcmalloc-cmake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests