Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Able to customize border around native ads (color, radius) #880

Open
naamapps opened this issue Jul 6, 2023 · 17 comments
Assignees
Labels
e2-days Effort: < 5 days feature request Feature request covers a product enhancement native ad Issues related to Native Ad

Comments

@naamapps
Copy link

naamapps commented Jul 6, 2023

Plugin Version

3.0.0

Steps to Reproduce

Just run a native ad on ios and see that it renders with a border around it.

Expected results:
The ad renders without borders.

Actual results:
The ad renders with borders.
See image:

flutter_06 copy

@malandr2 malandr2 added the feature request Feature request covers a product enhancement label Jul 6, 2023
@malandr2 malandr2 added p2-medium in triage Issue currently being evaluated labels Jul 6, 2023
@malandr2
Copy link
Collaborator

malandr2 commented Jul 6, 2023

Hi @naamapps,

The borders you are noticing are working as intended. I have labeled this case as a feature request and escalated to the greater team.

@malandr2 malandr2 closed this as completed Jul 6, 2023
@naamapps
Copy link
Author

naamapps commented Jul 6, 2023

Hey @malandr2,
Thanks for your quick comment.
Please explain why is this the intended behavior, it seems like a bug to me.
The borders are really distracting from the main content of the app.

Also why did you close the issue if it is not resolved?
Shouldn't it be open until it's resolved?

@malandr2
Copy link
Collaborator

malandr2 commented Jul 7, 2023

Hey @naamapps, ticket is re-opened. Will be closed once resolved by engineering.

The border is part of the UI and it is black by default. @jjliu15 feature request would be to allow customization of the border color.

@malandr2 malandr2 reopened this Jul 7, 2023
@naamapps
Copy link
Author

naamapps commented Jul 7, 2023

Got it.
Looking forward to this new feature to control the border color.
Also if it's possible, maybe add an option to control the border radius? Just suggesting a few customizations.
Thanks

@huycozy
Copy link
Collaborator

huycozy commented Jul 12, 2023

I also see this issue on Android as well. Updating labels corresponding to this. Verified on plugin versions: google_mobile_ads: ^3.0.0

Demo Android
Flutter plugin - Android Android native example

@huycozy huycozy added native ad Issues related to Native Ad e2-days Effort: < 5 days and removed in triage Issue currently being evaluated labels Jul 12, 2023
@huycozy huycozy changed the title iOS: Black borders around native ads [Feature request] Able to customize border around native ads (color, radius) Jul 12, 2023
@ravitaak
Copy link

ravitaak commented Sep 7, 2023

#842 (comment)

CHECK THIS

@malandr2
Copy link
Collaborator

malandr2 commented Oct 2, 2023

@ravitaak per your comment, we cannot recommend modifying the plugin code itself. I've re-raised this issue with the engineering team for visibility's sake. Thanks.

@naamapps
Copy link
Author

naamapps commented Oct 5, 2023

Thanks for your response @malandr2,
However every issue only seems for visibility's sake.
Why is there no actual work being done to resolve those critical issues?

This package looks abandoned and forgotten.
Please take this package seriously, and not like a side project.

@malandr2
Copy link
Collaborator

malandr2 commented Oct 5, 2023

Hey @naamapps, this specific issue isn't as high of a priority fix for the team compared to the others. Rest assured work is being done to address the larger issues in the list as well as implementing new features (those do not have any associated GitHub tracker).

@bcyran
Copy link

bcyran commented Oct 11, 2023

Commenting for issue visibility.

The current state of this feature bothers me a lot as it makes use cases for the native ads very limited. E.g. I want the ads to match the dark theme of my application. I can make the inside of the ad dark, but the white, eye-burning border stays there no matter what:

2023-10-11_19:14:30

bcyran added a commit to bcyran/googleads-mobile-flutter that referenced this issue Oct 11, 2023
@malandr2
Copy link
Collaborator

@bcyran, ACK. Thanks for your feedback.

@jhlee-danbi
Copy link

@malandr2
When will it be updated?
I am still waiting for the custom design features.

@fernandorascon
Copy link

Bump! Native ads have more potential for revenue growth than any other ad type, but it all depends on their ability to mesh well with the whole app's style. Introducing basic customization features shouldn't detract too much from other issues :(

@joshuamoreno1
Copy link

Hi there!,

Some news about it?

Thanks,

bcyran added a commit to bcyran/googleads-mobile-flutter that referenced this issue Jun 7, 2024
@DanielMartini
Copy link

Hi,

Any new about this? It doesn't make sense to use this kind of ad if it's not fully customizable with the UI

Thanks

@lancelotF
Copy link

lancelotF commented Aug 19, 2024

I managed to set the borders transparent by adding these two lines in my
android/app/src/main/res/values/styles.xml:

image

@ajith-ab
Copy link

ajith-ab commented Oct 6, 2024

For IOS Comment following line

ios/Classes/NativeTemplates/GoogleAdsMobileIosNativeTemplates/GADTTemplateView.m inside the package file

This helps me change the border and color.

- (void)applyStyles {
  // self.layer.borderColor =
  //     [GADTTemplateView colorFromHexString:@"E0E0E0"].CGColor;
  // self.layer.borderWidth = 1.0f;
  [self.mediaView sizeToFit];
  if ([self styleForKey:GADTNativeTemplateStyleKeyCornerRadius]) {
    float roundedCornerRadius =
        ((NSNumber *)[self styleForKey:GADTNativeTemplateStyleKeyCornerRadius])
            .floatValue;

    // Rounded corners
    self.iconView.layer.cornerRadius = roundedCornerRadius;
    self.iconView.clipsToBounds = YES;
    ((UIButton *)self.callToActionView).layer.cornerRadius =
        roundedCornerRadius;
    ((UIButton *)self.callToActionView).clipsToBounds = YES;
  }
...

}

happy coding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2-days Effort: < 5 days feature request Feature request covers a product enhancement native ad Issues related to Native Ad
Projects
None yet
Development

No branches or pull requests