-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] Able to customize border around native ads (color, radius) #880
Comments
Hi @naamapps, The borders you are noticing are working as intended. I have labeled this case as a feature request and escalated to the greater team. |
Hey @malandr2, Also why did you close the issue if it is not resolved? |
Got it. |
CHECK THIS |
@ravitaak per your comment, we cannot recommend modifying the plugin code itself. I've re-raised this issue with the engineering team for visibility's sake. Thanks. |
Thanks for your response @malandr2, This package looks abandoned and forgotten. |
Hey @naamapps, this specific issue isn't as high of a priority fix for the team compared to the others. Rest assured work is being done to address the larger issues in the list as well as implementing new features (those do not have any associated GitHub tracker). |
Commenting for issue visibility. The current state of this feature bothers me a lot as it makes use cases for the native ads very limited. E.g. I want the ads to match the dark theme of my application. I can make the inside of the ad dark, but the white, eye-burning border stays there no matter what: |
@bcyran, ACK. Thanks for your feedback. |
@malandr2 |
Bump! Native ads have more potential for revenue growth than any other ad type, but it all depends on their ability to mesh well with the whole app's style. Introducing basic customization features shouldn't detract too much from other issues :( |
Hi there!, Some news about it? Thanks, |
Hi, Any new about this? It doesn't make sense to use this kind of ad if it's not fully customizable with the UI Thanks |
For IOS Comment following line
This helps me change the border and color. - (void)applyStyles {
// self.layer.borderColor =
// [GADTTemplateView colorFromHexString:@"E0E0E0"].CGColor;
// self.layer.borderWidth = 1.0f;
[self.mediaView sizeToFit];
if ([self styleForKey:GADTNativeTemplateStyleKeyCornerRadius]) {
float roundedCornerRadius =
((NSNumber *)[self styleForKey:GADTNativeTemplateStyleKeyCornerRadius])
.floatValue;
// Rounded corners
self.iconView.layer.cornerRadius = roundedCornerRadius;
self.iconView.clipsToBounds = YES;
((UIButton *)self.callToActionView).layer.cornerRadius =
roundedCornerRadius;
((UIButton *)self.callToActionView).clipsToBounds = YES;
}
...
} happy coding! |
Plugin Version
3.0.0
Steps to Reproduce
Just run a native ad on ios and see that it renders with a border around it.
Expected results:
The ad renders without borders.
Actual results:
The ad renders with borders.
See image:
The text was updated successfully, but these errors were encountered: