Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we use google::protobuf::compiler::cpp::FieldName where needed when emitting code #14505

Open
scotthart opened this issue Jul 19, 2024 · 0 comments
Labels
cpp: generator Issues related to the C++ micro-generator type: cleanup An internal cleanup or hygiene concern.

Comments

@scotthart
Copy link
Member

In generator/internal/http_option_utils.cc, and maybe some other places, we emit code that uses the field name directly without first running it through google::protobuf::compiler::cpp::FieldName which handles the case where a field name is a C++ keyword or other disallowed token.

@scotthart scotthart added type: cleanup An internal cleanup or hygiene concern. cpp: generator Issues related to the C++ micro-generator labels Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp: generator Issues related to the C++ micro-generator type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

1 participant