From 8ed092efee6bd557bc49242aa3efdfc147d0372a Mon Sep 17 00:00:00 2001 From: Daniel Bruce Date: Thu, 23 Nov 2023 09:55:13 -0500 Subject: [PATCH] Stronger type checking for runAsync MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Use more specific types in the runAsync function so that the compiler will complain if anything isn’t right. --- src/transaction.ts | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/transaction.ts b/src/transaction.ts index 91e77bf1b..6513ad5af 100644 --- a/src/transaction.ts +++ b/src/transaction.ts @@ -759,7 +759,9 @@ class Transaction extends DatastoreRequest { * * **/ - async #runAsync(options: RunOptions): Promise> { + async #runAsync( + options: RunOptions + ): Promise> { const reqOpts: RequestOptions = { transactionOptions: {}, }; @@ -777,8 +779,10 @@ class Transaction extends DatastoreRequest { if (options.transactionOptions) { reqOpts.transactionOptions = options.transactionOptions; } - const promiseFunction: Resolver = ( - resolve: PromiseResolveFunction + const promiseFunction: Resolver< + google.datastore.v1.IBeginTransactionResponse + > = ( + resolve: PromiseResolveFunction ) => { this.request_( {