Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

sys.any slot filling doesn't fill with full phrase #386

Closed
MumblesNZ opened this issue Jul 16, 2019 · 9 comments
Closed

sys.any slot filling doesn't fill with full phrase #386

MumblesNZ opened this issue Jul 16, 2019 · 9 comments
Assignees
Labels
api: dialogflow Issues related to the googleapis/nodejs-dialogflow API. external This issue is blocked on a bug with the actual product. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@MumblesNZ
Copy link

Environment details

  • OS: Mac OS Mojave
  • Node.js version: v10.15.3
  • npm version: 6.9.0
  • dialogflow version: V2

Steps to reproduce

Create an agent & intent, enable slot filling for that intent, add some training phrases and parameters to the intent which have a @sys.any type.

Query detect-intent endpoint to trigger the intent so it enters into slot filling.

Query detect-intent endpoint with queryText: "end to end, this is my problem". Expect the slot to be completed with the full phrase: "end to end, this is my problem", but the slot is completed with "my problem".

Notes

I have a support ticket lodged also for this: 00722200 on the 5th of June, but haven't had any response yet.

Thanks.

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jul 17, 2019
@bcoe bcoe added type: question Request for information or clarification. Not an issue. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. external This issue is blocked on a bug with the actual product. and removed triage me I really want to be triaged. type: question Request for information or clarification. Not an issue. labels Jul 23, 2019
@MumblesNZ
Copy link
Author

Hey @bcoe, do you have any visibility on where this bug is sitting with regards to finding a solution?

@bcoe
Copy link
Contributor

bcoe commented Aug 2, 2019

You've done the right thing filing a support ticket (as it sounds like this issue might be related to the upstream API not the client). If you don't hear back within the next few days, please follow up with me again and I'll see if I can find someone on the dialogflow team to talk to internally.

@MumblesNZ
Copy link
Author

Hey @bcoe thanks for the response. To be honest the support ticket guys arn't responsive at all even if I send them followup emails. If you could put me in touch with someone in the dialogflow team who is aware of this issue that I can speak with that would be really helpful!!!

For anyone else who may land on this thread. I'm currently looking at a workaround at the moment, where I have an intent per param and I do my own slot filling via webhooks. I manually check which params arn't filled in, and set active contexts for any missing params in order. An added bonus of this is since we don't have the artificial contexts which the slot filling creates, we can manage the NLP state client side (passing in the contexts each time) which helps for rollouts & roll overs.

@nnegrey
Copy link
Contributor

nnegrey commented Aug 6, 2019

Do you mark the complete training phrases as @sys.any
Screen Shot 2019-08-06 at 9 38 31 AM

@MumblesNZ
Copy link
Author

Hey @nnegrey , an example of what we are doing is as below. I wouldn't expect it to pick sys-any-1 param up perfectly when you are initiating the intent. But when you enter into slot filling, and it prompts you for sys-any-1 param, I would expect any phrase said at that point to be entered into the sys-any-1 param, which is what our issue is.

Dialogflow around 4 months ago performed this slot filling function perfectly as described. It seems as though a change was made on the dialogflow backend which caused truncation of our sys.any phrases during slot filling.

image

@nnegrey
Copy link
Contributor

nnegrey commented Aug 7, 2019

Ah gotcha, sorry I misunderstood that this is a behavior change in the service. I've filed an internal bug and will follow up once I know more.

@MumblesNZ
Copy link
Author

Hey @nnegrey thanks for that. Any updates on the bug front?

@nnegrey
Copy link
Contributor

nnegrey commented Aug 14, 2019

Looks like it was also reported here: dialogflow/dialogflow-javascript-client#111

And the team is looking into a fix. But that was last updated on June 4th.

@callmehiphop
Copy link
Contributor

I'm going to close this out since it doesn't appear to be an issue with the client itself. If dialogflow/dialogflow-javascript-client#111 ends up being a dead end, I suggest opening an issue for this on the product forums.

@google-cloud-label-sync google-cloud-label-sync bot added the api: dialogflow Issues related to the googleapis/nodejs-dialogflow API. label Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: dialogflow Issues related to the googleapis/nodejs-dialogflow API. external This issue is blocked on a bug with the actual product. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

5 participants