Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-family repositories in crater #1124

Open
rsheeter opened this issue Nov 15, 2024 · 1 comment
Open

Support multi-family repositories in crater #1124

rsheeter opened this issue Nov 15, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@rsheeter
Copy link
Contributor

rsheeter commented Nov 15, 2024

To recruit more families into crater (https://googlefonts.github.io/fontc_crater/) add the ability to specify where config.yaml lives to METADATA.pb.

For example, Rubik Pixels doesn't compile identical, seems to have metadata (https://github.com/google/fonts/blob/main/ofl/rubikpixels/METADATA.pb), and doesn't appear to be represented on fontc crater. I think it's because it doesn't specify which config.yaml to use within the target repo.

It looks to me like we have no field to specify a path to config.yaml, perhaps we need to add one in https://github.com/googlefonts/gftools/blob/main/Lib/gftools/fonts_public.proto#L80 and use it when identifying sources (https://github.com/googlefonts/google-fonts-sources).

@rsheeter rsheeter added this to the fontc 1.0 milestone Nov 15, 2024
@rsheeter rsheeter self-assigned this Nov 15, 2024
@rsheeter rsheeter added correctness enhancement New feature or request and removed correctness labels Nov 15, 2024
@rsheeter
Copy link
Contributor Author

We also need to look for config.yaml as a sibling of METADATA.pb, as used by bigshoulders variants (per @simoncozens). Ex https://github.com/google/fonts/tree/main/ofl/bigshoulderstext

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant