Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparisons to the None object should be with identity, not equality #63

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

manlix
Copy link

@manlix manlix commented May 26, 2021

Hi.

I fixed comparisons to the None object according to Programming Recommendations — PEP-8:

Comparisons to singletons like None should always be done with is or is not, never the equality operators.

@google-cla
Copy link

google-cla bot commented May 26, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@manlix
Copy link
Author

manlix commented May 26, 2021

@googlebot I signed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant