You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In PR #46 , old tests are fixed and updated for the new data flow with dataset support. However, according to the comments from @Rhombus33 and @jnager , several code refactoring and changes are necessary to our current tests. These changes should implement the following items and be completed in one or more PRs:
Test the user-facing behavior instead of part of the implementation (i.e. if the tabs div is present in the DOM)
Assign literal values and anonymous functions to constants
Separate tests of a component with different type variable parameters to distinct describe blocks
Tests should import modules rather than declare components when setting up TestBed.
Should we rename xxx.component.spec.ts to xxx.module.spec.ts since we are now importing the entire module when testing?
In PR #46 , old tests are fixed and updated for the new data flow with dataset support. However, according to the comments from @Rhombus33 and @jnager , several code refactoring and changes are necessary to our current tests. These changes should implement the following items and be completed in one or more PRs:
xxx.component.spec.ts
toxxx.module.spec.ts
since we are now importing the entire module when testing?Before this issue gets resolved, tests should still be added and updated to each PR along with any new features or changes in the data flow.
The text was updated successfully, but these errors were encountered: