Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor unit tests #54

Open
jcc37-zz opened this issue Jul 10, 2020 · 2 comments
Open

Refactor unit tests #54

jcc37-zz opened this issue Jul 10, 2020 · 2 comments
Assignees

Comments

@jcc37-zz
Copy link
Collaborator

jcc37-zz commented Jul 10, 2020

In PR #46 , old tests are fixed and updated for the new data flow with dataset support. However, according to the comments from @Rhombus33 and @jnager , several code refactoring and changes are necessary to our current tests. These changes should implement the following items and be completed in one or more PRs:

  • Test the user-facing behavior instead of part of the implementation (i.e. if the tabs div is present in the DOM)
  • Assign literal values and anonymous functions to constants
  • Separate tests of a component with different type variable parameters to distinct describe blocks
  • Tests should import modules rather than declare components when setting up TestBed.
    • Should we rename xxx.component.spec.ts to xxx.module.spec.ts since we are now importing the entire module when testing?
  • Check insistent tests related to observable subscription Fix undeterministic test failure #76

Before this issue gets resolved, tests should still be added and updated to each PR along with any new features or changes in the data flow.

@64json
Copy link
Collaborator

64json commented Jul 11, 2020

@64json
Copy link
Collaborator

64json commented Jul 11, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants