Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating onboarding, branch naming and standard convention guideline #37

Open
louisgv opened this issue Apr 16, 2018 · 2 comments
Open
Assignees

Comments

@louisgv
Copy link
Member

louisgv commented Apr 16, 2018

New contributor will need:

  • Up-to-date Onboarding document (The current one might be deprecated)
  • Branch naming convention, i.e @<github_username>/<feature-or-bug-name>
  • Code convention with eslint and have a general guideline of having linter running before push. (We can enforce this with lint-staged).
@ColdSauce ColdSauce self-assigned this Apr 20, 2018
@ColdSauce
Copy link
Member

The Branch naming convention, i.e @<github_username>/<feature-or-bug-name> doesn't apply to contributors other than us since they won't have write access to our project. They would be working from their own pull requests.

@ColdSauce
Copy link
Member

lint-stage with lerna is something I'll set up in another PR. Let's stick with just documentation here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants