From ba2d3108fdd80c4c63cd4fa31613338db7b63081 Mon Sep 17 00:00:00 2001 From: Shark Date: Fri, 9 Aug 2024 12:02:20 +0200 Subject: [PATCH] upgrade v8 & fix compile error --- Cargo.lock | 5 ++--- crates/gosub_v8/Cargo.toml | 2 +- crates/gosub_v8/src/v8/context.rs | 5 ++++- crates/gosub_v8/src/v8/object.rs | 2 +- crates/gosub_webexecutor/Cargo.toml | 1 - 5 files changed, 8 insertions(+), 7 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 245b05ed8..221af2dc2 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1776,7 +1776,6 @@ dependencies = [ "paste", "serde_json", "thiserror", - "v8", ] [[package]] @@ -4480,9 +4479,9 @@ dependencies = [ [[package]] name = "v8" -version = "0.98.0" +version = "0.102.0" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "feb252d5be11c32cb4755d66d58db30ff30af5f1f17183e83ff54383a402c5f6" +checksum = "88a710d5b95bff79a90708203cf9f74384e080d21fc6664aa4df463f2c66ac83" dependencies = [ "bindgen", "bitflags 2.6.0", diff --git a/crates/gosub_v8/Cargo.toml b/crates/gosub_v8/Cargo.toml index f31bdd454..0477b465f 100644 --- a/crates/gosub_v8/Cargo.toml +++ b/crates/gosub_v8/Cargo.toml @@ -11,6 +11,6 @@ license = "MIT" gosub_shared = { path = "../gosub_shared" } gosub_webexecutor = { path = "../gosub_webexecutor" } thiserror = "1.0.61" -v8 = "0.98.0" +v8 = "0.102.0" anyhow = "1.0.86" serde_json = "1.0.122" \ No newline at end of file diff --git a/crates/gosub_v8/src/v8/context.rs b/crates/gosub_v8/src/v8/context.rs index 5c8704366..475e9c88a 100644 --- a/crates/gosub_v8/src/v8/context.rs +++ b/crates/gosub_v8/src/v8/context.rs @@ -94,7 +94,10 @@ impl<'a> V8Ctx<'a> { v8_ctx.handle_scope = handle_scope; - let ctx = v8::Context::new(unsafe { v8_ctx.handle_scope.as_mut() }.get()); + let ctx = v8::Context::new( + unsafe { v8_ctx.handle_scope.as_mut() }.get(), + Default::default(), + ); let ctx_scope = Box::new(ContextScope::new( unsafe { v8_ctx.handle_scope.as_mut() }.get(), diff --git a/crates/gosub_v8/src/v8/object.rs b/crates/gosub_v8/src/v8/object.rs index 5b8528e60..65cda3be3 100644 --- a/crates/gosub_v8/src/v8/object.rs +++ b/crates/gosub_v8/src/v8/object.rs @@ -277,7 +277,7 @@ impl<'a> JSObject for V8Object<'a> { _name: Local, value: Local, args: PropertyCallbackArguments, - _rv: ReturnValue| { + _rv: ReturnValue<()>| { let external = match Local::::try_from(args.data()) { Ok(external) => external, Err(e) => { diff --git a/crates/gosub_webexecutor/Cargo.toml b/crates/gosub_webexecutor/Cargo.toml index 92b16e059..a5c7c9a15 100644 --- a/crates/gosub_webexecutor/Cargo.toml +++ b/crates/gosub_webexecutor/Cargo.toml @@ -11,7 +11,6 @@ colored = "2.1.0" derive_more = "0.99" lazy_static = "1.5" thiserror = "1.0.61" -v8 = "0.98.0" anyhow = "1.0.86" paste = "1.0.15"