Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all to tokenizer tests from css-parsing-tests #175

Open
neuodev opened this issue Oct 24, 2023 · 2 comments
Open

Add all to tokenizer tests from css-parsing-tests #175

neuodev opened this issue Oct 24, 2023 · 2 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@neuodev
Copy link
Collaborator

neuodev commented Oct 24, 2023

To ensure that our CSS3 tokenizer adheres to the CSS3 specifications, we should include all tests from the css-parsing-tests repo.

I have already added a lot of tests, and the tokenizer is passing them all, but it is best to add them all to ensure we are covering all bases.

I will add some here and there, but for the time being, I will focus on the CSS3 parser.

Writing tests should be simple. Here is an example of writing this test from css-parsing-test into our tests

Considering the tokenizer, we only interested in tests in component_value_list.json file

@neuodev neuodev added the good first issue Good for newcomers label Oct 24, 2023
@neuodev neuodev self-assigned this Oct 24, 2023
@jaytaph
Copy link
Member

jaytaph commented Oct 24, 2023

Are we copying / transforming these tests into our codebase? Or could we use the tests "as-is" and have our code transform anything? I would opt for the latter, as we don't want to clutter our codebase with other people's code too much.

@neuodev
Copy link
Collaborator Author

neuodev commented Oct 24, 2023

I believe these tests were written for the "parser" rather than the "tokenizer," which is why I am using a single file.

I am planning to use this method for testing, after getting the parser ready, It will be better to use these tests "s-id"

@jaytaph jaytaph self-assigned this Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants