Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip root node in RenderTree iterator #295

Open
Kiyoshika opened this issue Dec 1, 2023 · 1 comment
Open

Skip root node in RenderTree iterator #295

Kiyoshika opened this issue Dec 1, 2023 · 1 comment
Labels
enhancement Updating/improving existing code good first issue Good for newcomers

Comments

@Kiyoshika
Copy link
Member

          Although now that I think about it, for the purpose of the `RenderTree`, the root node is technically not a visible node so should probably be skipped in the iterator itself

Originally posted by @Kiyoshika in #293 (comment)

@Kiyoshika Kiyoshika added the good first issue Good for newcomers label Dec 1, 2023
@Sharktheone
Copy link
Member

Makes sense to me. Else you'd have to always manually check if you are getting the root node. I think, when we need this, we could add another function like RenderTree::next_root.

@Kiyoshika Kiyoshika added the enhancement Updating/improving existing code label Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Updating/improving existing code good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants