-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert mod.rs
files
#296
Comments
it would be nice to have contribution guidelines. Would you like to take ownership of this and try to setup an initial one? |
I think, the reason was, because the mod.rs file was empty. I mentioned it in the PR, but i think, no one has seen it because the following messages were too big. |
Yeah I can put together an initial one |
@Kiyoshika I think you have created some? I only don't know where there are :-) |
What's the status of this? Should I make a PR to rename the |
i'm not sure where they are. I've seen some though,.. somewhere... :-) @Kiyoshika might know where |
ow.. this is really stupid from me... it is just in the https://github.com/gosub-browser/gosub-engine/blob/main/CONTRIBUTING.md :-) |
so, according to this contribution guide, we should use the non-mod.rs version. So yes, we should revert them back. |
oh, also completely missed that... |
From PR #268 we (accidentally) introduced
mod.rs
files again...we've gone back and forth multiple times about which convention to use and it seems our project prefers the other style of having
module_name.rs
and amodule_name/
directory (if necessary) instead ofmod.rs
filesI think we should make a note of this in our contribution guidelines as this is now the second time this has happened :P (and likely will happen more in the future unless we make people aware)
The text was updated successfully, but these errors were encountered: