Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert mod.rs files #296

Closed
Kiyoshika opened this issue Dec 1, 2023 · 9 comments · Fixed by #316
Closed

Revert mod.rs files #296

Kiyoshika opened this issue Dec 1, 2023 · 9 comments · Fixed by #316
Labels
refactor Anything related to refactoring

Comments

@Kiyoshika
Copy link
Member

From PR #268 we (accidentally) introduced mod.rs files again...

we've gone back and forth multiple times about which convention to use and it seems our project prefers the other style of having module_name.rs and a module_name/ directory (if necessary) instead of mod.rs files

I think we should make a note of this in our contribution guidelines as this is now the second time this has happened :P (and likely will happen more in the future unless we make people aware)

@jaytaph
Copy link
Member

jaytaph commented Dec 1, 2023

it would be nice to have contribution guidelines. Would you like to take ownership of this and try to setup an initial one?

@Sharktheone
Copy link
Member

I think, the reason was, because the mod.rs file was empty. I mentioned it in the PR, but i think, no one has seen it because the following messages were too big.

@Kiyoshika
Copy link
Member Author

it would be nice to have contribution guidelines. Would you like to take ownership of this and try to setup an initial one?

Yeah I can put together an initial one

@Kiyoshika Kiyoshika added the refactor Anything related to refactoring label Dec 2, 2023
@jaytaph
Copy link
Member

jaytaph commented Dec 11, 2023

@Kiyoshika I think you have created some? I only don't know where there are :-)

@Sharktheone
Copy link
Member

What's the status of this? Should I make a PR to rename the mod.rs files again? I'm not really good at writing things like contribution guidelines, so I probably shouldn't be the person to write them.

@jaytaph
Copy link
Member

jaytaph commented Dec 14, 2023

i'm not sure where they are. I've seen some though,.. somewhere... :-) @Kiyoshika might know where

@jaytaph
Copy link
Member

jaytaph commented Dec 14, 2023

ow.. this is really stupid from me... it is just in the https://github.com/gosub-browser/gosub-engine/blob/main/CONTRIBUTING.md

:-)

@jaytaph
Copy link
Member

jaytaph commented Dec 14, 2023

so, according to this contribution guide, we should use the non-mod.rs version. So yes, we should revert them back.

@Sharktheone
Copy link
Member

ow.. this is really stupid from me... it is just in the https://github.com/gosub-browser/gosub-engine/blob/main/CONTRIBUTING.md

:-)

oh, also completely missed that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Anything related to refactoring
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants