Move "global" tests from ./tests to the correct crates #445
Labels
Comments
jaytaph
added
good first issue
|
Hello! I'm new to all of this and looking for a contribution I may be able to make to this project, for an assignment in my class I'm taking on FOSS. I was interested in taking this on, but I am a bit unclear on it. I am unsure specifically which files need to get moved out of the tests folder, and where they should be put in the crates folder. I've also put this message on the Zulip. |
Sharktheone
pushed a commit
that referenced
this issue
May 27, 2024
#445 (#457) * Moved tokenizer.rs from tests to crates Moved tokenizer.rs from tests to its crate. Also added the #[cfg(test)] and mod declaration as requested. * Deleted tokenizer.rs from tests folder. It was copied into its crate. * Copied tree_construction.rs from tests into a crate. Copied tree_construction.rs from tests into its specific crate. I also put it in the module as requested. * Deleted tree_construction.rs from the test folder Deleted tree_construction.rs from the test folder as it was copied over to a crate * Update and rename test.rs to tests.rs Removes the #[cfg(test)] from the file and removed extra indentation. Also renamed it to tests.rs as asked. * Update tokenizer.rs * Delete tests/lib.rs * Update Cargo.toml Deleted the [[test]] lines. * cargo add test_case --dev -p gosub_html5 * make format * import gosub testing in html5 crate * move testing data * apply diff from PR to fix final changes * remove benchmarks that the other patch didnt get --------- Co-authored-by: Adrian Edwards <[email protected]>
|
Completed in #457 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are a few tests in the root directory
./testsdir. These should be moved to the correct crate found in./crates.The text was updated successfully, but these errors were encountered: