Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fixture root is not correct for some tests #521

Open
jaytaph opened this issue Jul 21, 2024 · 0 comments
Open

Test fixture root is not correct for some tests #521

jaytaph opened this issue Jul 21, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers tests Anything related to tests

Comments

@jaytaph
Copy link
Member

jaytaph commented Jul 21, 2024

When running make test, the system will run ./src/bin/parser-test.rs. This tries to find the tests in FIXTURE_ROOT, but they are not present there. However, the tests in the gosub_html5 crate, do find these tests at the correct position, mainly because the FIXTURE_ROOT is a relative path.

We somehow must make this more consistent so we can run both make test, and have the CI pass

@jaytaph jaytaph added bug Something isn't working good first issue Good for newcomers tests Anything related to tests labels Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers tests Anything related to tests
Projects
Status: 📝 Todo
Development

No branches or pull requests

1 participant