Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Firehose] Secret resource creation should be conditional #85

Open
rajat404 opened this issue Apr 5, 2024 · 0 comments
Open

[Firehose] Secret resource creation should be conditional #85

rajat404 opened this issue Apr 5, 2024 · 0 comments

Comments

@rajat404
Copy link

rajat404 commented Apr 5, 2024

Currently as per the secret template, the secret and secret mount resources are created for each helm release even if no secrets are provided in the values file.

The secret resource creation should be conditional on the presence of non-empty values for those fields in the values file.

This can be done by adding an if condition block in secrets.yaml for each - secret and secret mount.

I'd be happy to raise a PR for this, if the maintainers agree with the proposed change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant