From 54777a8736de9e0c2152bf62132ea4369238b7f7 Mon Sep 17 00:00:00 2001 From: luthfifahlevi <77453015+luthfifahlevi@users.noreply.github.com> Date: Thu, 22 Aug 2024 14:55:28 +0700 Subject: [PATCH] fix: resolve linter issues (#80) Co-authored-by: Muhammad Luthfi Fahlevi --- internal/server/v1beta1/asset_test.go | 8 ++++---- internal/store/postgres/asset_repository.go | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/internal/server/v1beta1/asset_test.go b/internal/server/v1beta1/asset_test.go index 8036a25b..516e3a91 100644 --- a/internal/server/v1beta1/asset_test.go +++ b/internal/server/v1beta1/asset_test.go @@ -999,7 +999,7 @@ func TestDeleteAssets(t *testing.T) { DryRun bool ExpectStatus codes.Code ExpectResult *compassv1beta1.DeleteAssetsResponse - Setup func(ctx context.Context, as *mocks.AssetService, astID string) + Setup func(ctx context.Context, as *mocks.AssetService) } testCases := []TestCase{ @@ -1009,7 +1009,7 @@ func TestDeleteAssets(t *testing.T) { DryRun: false, ExpectStatus: codes.InvalidArgument, ExpectResult: nil, - Setup: func(ctx context.Context, as *mocks.AssetService, astID string) { + Setup: func(ctx context.Context, as *mocks.AssetService) { as.EXPECT().DeleteAssets(ctx, dummyRequest).Return(0, errors.New("something wrong")) }, }, @@ -1019,7 +1019,7 @@ func TestDeleteAssets(t *testing.T) { DryRun: false, ExpectStatus: codes.OK, ExpectResult: &compassv1beta1.DeleteAssetsResponse{AffectedRows: 11}, - Setup: func(ctx context.Context, as *mocks.AssetService, astID string) { + Setup: func(ctx context.Context, as *mocks.AssetService) { as.EXPECT().DeleteAssets(ctx, dummyRequest).Return(11, nil) }, }, @@ -1032,7 +1032,7 @@ func TestDeleteAssets(t *testing.T) { mockUserSvc := new(mocks.UserService) mockAssetSvc := new(mocks.AssetService) if tc.Setup != nil { - tc.Setup(ctx, mockAssetSvc, assetID) + tc.Setup(ctx, mockAssetSvc) } defer mockUserSvc.AssertExpectations(t) defer mockAssetSvc.AssertExpectations(t) diff --git a/internal/store/postgres/asset_repository.go b/internal/store/postgres/asset_repository.go index 001c9811..28d58bf8 100644 --- a/internal/store/postgres/asset_repository.go +++ b/internal/store/postgres/asset_repository.go @@ -384,7 +384,7 @@ func (r *AssetRepository) DeleteByURN(ctx context.Context, urn string) error { func (r *AssetRepository) DeleteByQueryExpr(ctx context.Context, queryExpr queryexpr.ExprStr) ([]string, error) { var urns []string - err := r.client.RunWithinTx(ctx, func(tx *sqlx.Tx) error { + err := r.client.RunWithinTx(ctx, func(*sqlx.Tx) error { query, err := queryexpr.ValidateAndGetQueryFromExpr(queryExpr) if err != nil { return err