From cd81a695b5fe6e8e445100b72e0bfd6be2a1e5c6 Mon Sep 17 00:00:00 2001 From: Muhammad Luthfi Fahlevi Date: Thu, 8 Aug 2024 15:28:56 +0700 Subject: [PATCH] feat(docs): add comments in QueryExprTranslator --- pkg/translator/query_expr_translator.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pkg/translator/query_expr_translator.go b/pkg/translator/query_expr_translator.go index cda07941..78d508b3 100644 --- a/pkg/translator/query_expr_translator.go +++ b/pkg/translator/query_expr_translator.go @@ -35,6 +35,8 @@ func (q *QueryExprTranslator) ConvertToSQL() (string, error) { return q.SqlQuery.String(), nil } +// TranslateToSQL The idea came from ast.Walk. Currently, the development focus implement for the node type that most likely used in our needs. +// TODO: implement translator for node type that still not covered right now. func (q *QueryExprTranslator) TranslateToSQL(node *ast.Node, translator *QueryExprTranslator) { if *node == nil { return @@ -175,6 +177,8 @@ func (q *QueryExprTranslator) ConvertToEsQuery() (string, error) { return string(queryJSON), nil } +// TranslateToEsQuery The idea came from ast.Walk. Currently, the development focus implement for the node type that most likely used in our needs. +// TODO: implement translator for node type that still not covered right now. func (q *QueryExprTranslator) TranslateToEsQuery(node *ast.Node) interface{} { if *node == nil { return nil