Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emulsify_twig module to GovCMS #688

Open
rod-higgins opened this issue Feb 3, 2023 · 1 comment
Open

Add emulsify_twig module to GovCMS #688

rod-higgins opened this issue Feb 3, 2023 · 1 comment

Comments

@rod-higgins
Copy link

** What value does this module/package add to GovCMS?

Allows for the required twig extensions needed for developing themes using emulsify.

** Is the module Drupal 10 compatible?

Yes.

** Please provide a brief outline of what this module does.

Adds 2 twig extensions which are dependencies in the emulsify patternlab kits. The source code for the module does nothing else. Emulsify is a modern front end build system that enables developers to build out themes using modern web components based on atomic design principles, design systems, figma UI kits.

** Who does this module benefit:
[] end users
[ ] content editors
[
] site builders
[] themers
[
] developers

End users - fully complaint WCAG 2.1 themes out of box via emulsify
Site builders - ability to use web components via atomic design
Themers - figma UI kits, theme linting / testing out the box, clean reusable themes across projects
Developers - web component based FE developement

** How could you provide/replicate the functionality of this module using alternative methods, eg in your theme?

Currently I do not believe it's possible to create custom twig functions in a theme - only through a module.

** If this module styles or alters HTML or JavaScript output, can the functionality be provided via the theme? What alternatives have you considered.

As above twig functions are only possible in modules.

** What is the maintenance and support status of the module. Describe the issue queue activity.

At time of writing the module is used in 3.7K installs and only 2 issues on latest version which are both under review
https://www.drupal.org/project/issues/emulsify_twig?text=&status=Open&priorities=All&categories=All&version=all_2.1.*&component=All

** What permissions are needed to utilise the module (and are any new permissions provided by the module)?

None.

** Does the module modify the database structure and/or store additional metadata on nodes or other entities? If so, why? What are the risks for future updates?

No.

** Is the module designed to capture anonymous user data?

No.

** Is the output of the module typically fully cacheable? Would the inclusion of this module potentially render pages uncacheable.

Not relevant. Handled through twig caching.

** What is your assessment of the quality of this module, the contribution history of the module's maintainers, and the uptake of the module within the Drupal community?

As above 3.7K active installs. Needed for D10 compatible themes based on emulsify. The module is very minor with only 2 small php classes, but highly active and opens up the ability for govCMS themers to use patternlab themes and modern tooling like webpack to build out. Amongst a lot of other FE goodness.

** Additional information

If can't be added blocks out using emulsify themes from govCMS.

@thisisalistairsaccount
Copy link

Hi @rod-higgins I'll mark this as "Requires more community feedback/interest" for the time being. I'm not sure of the overall use or interest in the Emulsify Design System in the GovCMS programme, or other design systems that could leverage this or something else. If anyone in the community is interested, please leave comments on this issue to show us your interest.

You've mentioned it's D10 compatible, but I can't currently see a D10 compatible version. Can you confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants