Find more performant way to enable required modules

[tobybellwood]

In
https://github.com/govCMS/govcms8lagoon/blob/master/.docker/images/govcms8/scripts/govcms-deploy#L66
we perform an enable/uninstall of the govcms_lagoon module, which is only used to ensure that the dependencies listed in
https://github.com/govCMS/govcms8lagoon/blob/master/modules/lagoon/govcms_lagoon/govcms_lagoon.info.yml#L8
Surely there's a better way (surely?)

[simesy]

My opinion is we have a module that is production friendly. Leave it enabled. Disable features locally, if possible through settings.php and friends.

[simesy]

imo, It's more reliable to vet this state than to alter the application during deplyment and hope it matches a state.

[tobybellwood]

how can we ensure that the module is enabled in prod (or undisable-able)?

[simesy]

I can think of a few ways (particularly in light of the new paas scaffold/ci). vetting job, form validation/alteration for the UI modules, some code in the scaffold settings.php that just ensures the modules are there, etc, etc. I mean it's going to be a bit custom but if the gains are significant then i think it's worth it.