Skip to content

Commit

Permalink
Add parameter validation for asinh (#3559)
Browse files Browse the repository at this point in the history
This CL adds tests for parameter validation to the `asinh` builtin.
  • Loading branch information
dj2 authored Mar 26, 2024
1 parent c3b50f7 commit 262084f
Show file tree
Hide file tree
Showing 2 changed files with 121 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/webgpu/listing_meta.json
Original file line number Diff line number Diff line change
Expand Up @@ -1888,6 +1888,7 @@
"webgpu:shader,validation,expression,call,builtin,asin:parameters:*": { "subcaseMS": 20072.777 },
"webgpu:shader,validation,expression,call,builtin,asin:values:*": { "subcaseMS": 0.359 },
"webgpu:shader,validation,expression,call,builtin,asinh:integer_argument:*": { "subcaseMS": 1.267 },
"webgpu:shader,validation,expression,call,builtin,asinh:parameters:*": { "subcaseMS": 17189.159 },
"webgpu:shader,validation,expression,call,builtin,asinh:values:*": { "subcaseMS": 0.372 },
"webgpu:shader,validation,expression,call,builtin,atan2:integer_argument_x:*": { "subcaseMS": 0.912 },
"webgpu:shader,validation,expression,call,builtin,atan2:integer_argument_y:*": { "subcaseMS": 0.867 },
Expand Down
120 changes: 120 additions & 0 deletions src/webgpu/shader/validation/expression/call/builtin/asinh.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -89,3 +89,123 @@ Validates that scalar and vector integer arguments are rejected by ${builtin}()
'constant'
);
});

const kTests = {
valid: {
src: `_ = asinh(1);`,
pass: true,
},
alias: {
src: `_ = asinh(f32_alias(1));`,
pass: true,
},

bool: {
src: `_ = asinh(false);`,
pass: false,
},
i32: {
src: `_ = asinh(1i);`,
pass: false,
},
u32: {
src: `_ = asinh(1u);`,
pass: false,
},
vec_bool: {
src: `_ = asinh(vec2<bool>(false, true));`,
pass: false,
},
vec_i32: {
src: `_ = asinh(vec2<i32>(1, 1));`,
pass: false,
},
vec_u32: {
src: `_ = asinh(vec2<u32>(1, 1));`,
pass: false,
},
matrix: {
src: `_ = asinh(mat2x2(1, 1, 1, 1));`,
pass: false,
},
atomic: {
src: ` _ = asinh(a);`,
pass: false,
},
array: {
src: `var a: array<u32, 5>;
_ = asinh(a);`,
pass: false,
},
array_runtime: {
src: `_ = asinh(k.arry);`,
pass: false,
},
struct: {
src: `var a: A;
_ = asinh(a);`,
pass: false,
},
enumerant: {
src: `_ = asinh(read_write);`,
pass: false,
},
ptr: {
src: `var<function> a = 1f;
let p: ptr<function, f32> = &a;
_ = asinh(p);`,
pass: false,
},
ptr_deref: {
src: `var<function> a = 1f;
let p: ptr<function, f32> = &a;
_ = asinh(*p);`,
pass: true,
},
sampler: {
src: `_ = asinh(s);`,
pass: false,
},
texture: {
src: `_ = asinh(t);`,
pass: false,
},
no_params: {
src: `_ = asinh();`,
pass: false,
},
too_many_params: {
src: `_ = asinh(1, 2);`,
pass: false,
},
};

g.test('parameters')
.desc(`Test that ${builtin} is validated correctly.`)
.params(u => u.combine('test', keysOf(kTests)))
.fn(t => {
const src = kTests[t.params.test].src;
const code = `
alias f32_alias = f32;
@group(0) @binding(0) var s: sampler;
@group(0) @binding(1) var t: texture_2d<f32>;
var<workgroup> a: atomic<u32>;
struct A {
i: u32,
}
struct B {
arry: array<u32>,
}
@group(0) @binding(3) var<storage> k: B;
@vertex
fn main() -> @builtin(position) vec4<f32> {
${src}
return vec4<f32>(.4, .2, .3, .1);
}`;
t.expectCompileResult(kTests[t.params.test].pass, code);
});

0 comments on commit 262084f

Please sign in to comment.