New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: find and deduplicate fullscreen quad shader code #3344

Open

kainino0x opened this issue Jan 27, 2024 · 1 comment

Collaborator

kainino0x commented Jan 27, 2024

We have a lot of these. A quick search for (-1.0, -1.0) and similar strings found them in:

same_subresource.spec.ts
canvas_complex.spec.ts
video.spec.ts
format_reinterpretation.spec.ts
read_write.spec.ts
depth_bias.spec.ts
clear_values.spec.ts
image_copy.spec.ts
copyTextureToTexture.spec.ts (renderPipelineForValidation)
color_target_state.spec.ts (this one is a fullscreen triangle)
culling_tests.spec.ts (this one is a fullscreen triangle)

The text was updated successfully, but these errors were encountered:

Collaborator Author

kainino0x commented Jan 27, 2024

#3333 adds kFullscreenQuadVertexShaderCode which we can use to replace many of these.

kainino0x mentioned this issue

webgpu,api,operation,texture_view,write:format:* #3333

Merged

7 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment