Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

val: Test that two 'auto' BGLs at different group indices on the same pipeline are compatible #3388

Closed
kainino0x opened this issue Feb 12, 2024 · 1 comment · Fixed by #3382

Comments

@kainino0x
Copy link
Collaborator

kainino0x commented Feb 12, 2024

In that case we need to test that 2 bind groups that appear the same, are the same? In other words

      @group(0) @binding(0) var s1: sampler;
      @group(0) @binding(1) var t1: texture_2d<f32>;

      @group(1) @binding(0) var s2: sampler;
      @group(1) @binding(1) var t2: texture_2d<f32>;

If we use layout: 'auto' on this then a bindGroup made with pipeline.getBindGroupLayout(0) should work bound to bind group 1.

I don't think there is a test for that and it would be easy for browsers to disagree on this without a test?

Originally posted by @greggman in #3374 (comment)

@kainino0x kainino0x added this to CTS Feb 12, 2024
@kainino0x kainino0x moved this to Open (no TODO) in CTS Feb 12, 2024
@greggman
Copy link
Contributor

#3382

@kainino0x kainino0x linked a pull request Feb 13, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Open (no TODO)
Development

Successfully merging a pull request may close this issue.

2 participants