Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgsl: Add discussion about how OOB-ness is inherited #3234

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

zoddicus
Copy link
Contributor

@zoddicus zoddicus commented Jan 3, 2024

Covers the details of scalar, vector, and matrix operations.

Also includes a few minor cleanups to other sections of the doc that I made while reviewing the text.

Issue #3191


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@zoddicus zoddicus added the wgsl label Jan 3, 2024
@zoddicus zoddicus self-assigned this Jan 3, 2024
@zoddicus
Copy link
Contributor Author

zoddicus commented Jan 3, 2024

I will review the CTS code and send up a seperate PR if there are code-side changes needed to conform with this discussion.

Copy link
Contributor

@jiangzhaoming jiangzhaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

I think the description added here is what we are already trying to emplace in the CTS implementation now, right? I think I can learn the general idea of simulating the possible computation steps (maybe multiple path) and flow the intermediate OOB to the result when following the implementation, and element-wise operation do such simulation in element-wise manner to get a possibly OOB-mixed result expectation.

Copy link
Contributor

@ben-clayton ben-clayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoddicus
Copy link
Contributor Author

zoddicus commented Jan 4, 2024

Looks good to me, thanks!

I think the description added here is what we are already trying to emplace in the CTS implementation now, right? I think I can learn the general idea of simulating the possible computation steps (maybe multiple path) and flow the intermediate OOB to the result when following the implementation, and element-wise operation do such simulation in element-wise manner to get a possibly OOB-mixed result expectation.

The CTS is currently slightly inconsistent in this regard, but this is what was intended to be implemented. I have a WIP patch that fixes up a number of places that were incorrect that I should be sending up for review later today.

Covers the details of scalar, vector, and matrix operations.

Also includes a few minor cleanups to other sections of the doc that I
made while reviewing the text.

Fixes gpuweb#3191
@zoddicus zoddicus force-pushed the addVectorMatrixOOBPrimer branch from 35b3cd0 to 39c7724 Compare January 4, 2024 15:44
@zoddicus zoddicus merged commit dc4dbef into gpuweb:main Jan 4, 2024
1 check passed
@zoddicus zoddicus deleted the addVectorMatrixOOBPrimer branch January 4, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants