Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fullyExpandSubtrees & ability to disable no long path assert #3246

Merged
merged 5 commits into from
Jan 17, 2024

Conversation

sagudev
Copy link
Collaborator

@sagudev sagudev commented Jan 8, 2024

Assert is not valid (at least in servo's case) as only one expectation file is used for all variants. Another option would be to reduce assert to warning (depending on how much it is needed elsewhere).

fullyExpandSubtrees expends all subs recursively that are part of provided query.

Issue: #3233


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@sagudev sagudev force-pushed the all-variants branch 2 times, most recently from a2d9441 to dd3fb51 Compare January 8, 2024 13:29
@sagudev sagudev force-pushed the all-variants branch 3 times, most recently from ac3b68c to af3a2f6 Compare January 13, 2024 08:42
@sagudev sagudev changed the title expendAll strategy for expectations & ability to disable no long path assert fullyExpandSubtrees & ability to disable no long path assert Jan 13, 2024
@sagudev sagudev requested a review from kainino0x January 13, 2024 08:50
Path length does not play a role in servo (it's only limited by URI max size)
Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the revision!

@kainino0x kainino0x enabled auto-merge (squash) January 17, 2024 04:57
@kainino0x kainino0x merged commit e082b08 into gpuweb:main Jan 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants