Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fragment builtins: document missing test, or other places to find them #3339

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

dneto0
Copy link
Contributor

@dneto0 dneto0 commented Jan 26, 2024


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@dneto0 dneto0 force-pushed the frag-builtins-todo branch 2 times, most recently from 69c11d9 to 1e8d1bd Compare January 29, 2024 14:38
@dneto0 dneto0 requested a review from greggman January 29, 2024 15:52
@dneto0
Copy link
Contributor Author

dneto0 commented Jan 29, 2024

@greggman thanks for doing all the hard work. I added this to make explicit the missing coverage that I could see.

Copy link
Contributor

@greggman greggman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sample_mask output seems to be tested here

src/webgpu/api/operation/render_pipeline/sample_mask.spec.ts

frag_depth output seems to be indirectly tested here

src/webgpu/api/operation/rendering/depth_clip_clamp.spec.ts

Maybe a comment?

@dneto0 dneto0 force-pushed the frag-builtins-todo branch 3 times, most recently from 29978f5 to af5527f Compare February 13, 2024 21:49
@dneto0 dneto0 changed the title Add .unimplemented() fragment builtins execution tests fragment builtins: document missing test, or other places to find them Feb 13, 2024
@dneto0
Copy link
Contributor Author

dneto0 commented Feb 13, 2024

sample_mask output seems to be tested here
...
frag_depth output seems to be indirectly tested here
...
Maybe a comment?

Thanks! As they say, the best way to get the right answer on the Internet is to post the wrong answer.

Changed the text to point to those other places, and to keep the sample_mask input test as unimplemented, but with a suggestion to extend the sample_mask output test. (I'd say it's a strong recommendation, but hopefully it will be obvious.)

PTAL. @greggman

Copy link
Contributor

@greggman greggman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dneto0 dneto0 enabled auto-merge (rebase) February 14, 2024 15:55
@dneto0 dneto0 force-pushed the frag-builtins-todo branch from af5527f to f6e5de4 Compare February 14, 2024 15:56
@dneto0 dneto0 merged commit 631bae0 into gpuweb:main Feb 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants