Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'trackForCleanUp' to destroy HTMLVideoElement #3365

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

shaoboyan
Copy link
Contributor

@shaoboyan shaoboyan commented Feb 4, 2024

This PR adds HTMLVideoElement as DestroyObject type and uses 'trackForCleanUp' to reset video element source and srcObject after case finished.

Fix:#3364

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

This PR adds HTMLVideoElement as DestroyObject type and uses
'trackForCleanUp' to reset video element source and srcObject
after case finished.

Fix:gpuweb#3364
@shaoboyan
Copy link
Contributor Author

TBH, mark HTMLVideoElement as DestroyableObject is a bit weired. But I think leverage trackForCleanUp() to release such resource is reasonable.

Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this definitely should work better!
trackForCleanup is already very polymorphic so IMO this is a perfect addition to it.

@kainino0x kainino0x merged commit e05aad5 into gpuweb:main Feb 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants