-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test maxBindGroupsPlusVertexBuffers limits #3368
Test maxBindGroupsPlusVertexBuffers limits #3368
Conversation
Note: All of the tests are skipped on Chrome since Chrome doesn't currently set On Safari Technology Preview the tests that are within the limits pass, those that are past the limit fail as not generating an error. For the draw tests, they current fail because Safari disallows calling |
I'll try this locally since Safari Technology Preview doesn't include validation for these tests yet, I just noticed it while adding it locally. I have a PR open to add the validation, it hasn't merged yet. |
56e2325
to
48d1d69
Compare
I updated to use empty bindGroupLayouts as suggested by @kainino0x so the explicit pipeline layouts path is now enabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/webgpu/api/validation/capability_checks/limits/maxBindGroupsPlusVertexBuffers.spec.ts
Outdated
Show resolved
Hide resolved
src/webgpu/api/validation/capability_checks/limits/limit_utils.ts
Outdated
Show resolved
Hide resolved
src/webgpu/api/validation/capability_checks/limits/limit_utils.ts
Outdated
Show resolved
Hide resolved
src/webgpu/api/validation/capability_checks/limits/maxBindGroupsPlusVertexBuffers.spec.ts
Outdated
Show resolved
Hide resolved
src/webgpu/api/validation/capability_checks/limits/maxBindGroupsPlusVertexBuffers.spec.ts
Outdated
Show resolved
Hide resolved
src/webgpu/api/validation/capability_checks/limits/maxBindGroupsPlusVertexBuffers.spec.ts
Outdated
Show resolved
Hide resolved
src/webgpu/api/validation/capability_checks/limits/maxBindGroupsPlusVertexBuffers.spec.ts
Outdated
Show resolved
Hide resolved
src/webgpu/api/validation/capability_checks/limits/limit_utils.ts
Outdated
Show resolved
Hide resolved
…psPlusVertexBuffers.spec.ts Co-authored-by: Kai Ninomiya <[email protected]>
…psPlusVertexBuffers.spec.ts Co-authored-by: Kai Ninomiya <[email protected]>
…psPlusVertexBuffers.spec.ts Co-authored-by: Kai Ninomiya <[email protected]>
…psPlusVertexBuffers.spec.ts Co-authored-by: Kai Ninomiya <[email protected]>
0bce1e1
to
d787abf
Compare
Here's an updated test for
maxBindGroupPlusVertexBuffers
. I can't easily test with explicit pipeline layouts because it's currently impossible to create sparse explicit pipeline layouts but the code is there for when it becomes possible which seems like a future plan.Requirements for PR author:
.unimplemented()
./** documented */
and new helper files are found inhelper_index.txt
.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.