op: read-only storage textures - Part I #3370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds the operation tests on 2D read-only storage textures in compute shaders. This patch also adds the missing "trackForCleanup" in the operations tests on read-write storage textures.
Kangz
approved these changes
Feb 7, 2024
| import { GPUTest } from '../../../gpu_test.js'; | ||
|
|
||
| function ComponentCount(format: ColorTextureFormat): number { | ||
| switch (format) { |
There was a problem hiding this comment.
IMHO this should be in format_info. We could make an issue for this in gpuweb/cts and do it later.
There was a problem hiding this comment.
Ack. Filed #3375 to track this issue.
Kangz
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the operation tests on 2D read-only storage textures in compute shaders.
This patch also adds the missing "trackForCleanup" in the operations tests on read-write storage textures.
Issue: #3078
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.