Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge upstream vm-23.1.5 tag 1st batch #46

Merged
merged 24 commits into from
Feb 17, 2025
Merged

Merge upstream vm-23.1.5 tag 1st batch #46

merged 24 commits into from
Feb 17, 2025

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Feb 12, 2025 •
edited
Loading

1st batch of #37

Backports:

Note

eed5f79a666 [GR-52780] Backport to 23.1: FileSystemsTest#testSetAttribute() fails on JDK-23-linux. is not part of this backport because it has been separately backported in #20

The backports are clean, there were no conflicts.

OracleLabsAutomation and others added 24 commits February 12, 2025 12:16
@OracleLabsAutomation @zakkak
Update JVMCI to 23.1-b38 (jdk-21.0.4+3)
4dad67b 
(cherry picked from commit a44a8d3)
@jovanstevanovic @zakkak
Update -g to include all informaton for profiling on Linux.
c1d0520 
(cherry picked from commit e9e411e)
@jovanstevanovic @zakkak
Strip debug sections unconditionally.
0d7b8bf 
(cherry picked from commit a7b524e)
@gergo- @zakkak
Use correct compare size in AMD64NormalizedUnsignedCompareOp
cd29baa 
(cherry picked from commit 2a2d7bb)
@christianhaeubl @zakkak
Change CCharPointer from "char" to "signed char".
adc00a8 
(cherry picked from commit 6a5861e)
@rmosaner @zakkak
[GR-52657] Fix simplification of always-deopt FixedGuard.
6b7184d 
(cherry picked from commit 1b7238b)
@elkorchi @zakkak
Adapt fix
7a9b485 
(cherry picked from commit 0193b85)
@farquet @zakkak
E3 benchmarking migration
cc0e6de 
(cherry picked from commit 77b88cc)
@farquet @zakkak
Reduce frequency of baseline benchmarks
e41d71e 
(cherry picked from commit 58d0dbb)
@farquet @zakkak
Migrate remaining bench jobs to E3
8d3fa42 
(cherry picked from commit 4fdcc7c)
@farquet @zakkak
Drop x52 machine type
282b260 
(cherry picked from commit 05e25e0)
@farquet @zakkak
Force PMU for perf
f8d5f0f 
(cherry picked from commit a54f2eb)
@elkorchi @zakkak
Fix enumerator issue add missing field
a480330 
(cherry picked from commit de74c30)
@elkorchi @zakkak
update ci-overlay
14893cf 
(cherry picked from commit 534b97a)
@elkorchi @zakkak
fix style issue sync file
30eb547 
(cherry picked from commit e9baa36)
@elkorchi @zakkak
Update ci commit
50b163e 
(cherry picked from commit 317c1b9)
@marwan-hallaoui @zakkak
update ci-overlay
666b0c6 
(cherry picked from commit 590874b)
@c-refice @zakkak
Add epsilon to more floating-point probability comparisons
c436628 
(cherry picked from commit c558689)
@c-refice @zakkak
Add helper methods for approximate comparisons to ProfileData
b5eb3bf 
(cherry picked from commit 1c37f51)
@peter-hofer @zakkak
Make reference processing more robust, especially against OOME during…
951a07e 
… tear-down.

(cherry picked from commit 8319494)
@elkorchi @zakkak
Adapt fix to 23.1
fc25f2a 
(cherry picked from commit eef8d9a)
@christianhaeubl @zakkak
[GR-53541] Fixed a deadlock if we run OutOfMemory while entering a sy…
7715c26 
…nchronized blocks.

(cherry picked from commit 25f7ffc7731fe3224446ad338a7c447c4df8332c)
@christianhaeubl @zakkak
[GR-53407] Optionally ignore OutOfMemoryErrors while in VM-internal c…
69f685d 
…ode.

(cherry picked from commit 7922f87b7e2cf44f084a1ea359da0c3643d269b3)
@jchalou @zakkak
Use all active contexts for CPUSampler#takeSample. Don't store hard r…
a5083fd 
…eferences to contexts on the engine.

(cherry picked from commit 6c20487)

6c20487 appears to be a squash commit
of the changes in oracle/graal#8759 which
include the following commits:

* e3dd860
* e77be20
* 85303f9
* 4f5de74
* dd810f0
* ef4d967
* 5d86317
* 8efd0f3
* 7e0bb41
* cccfa5e
* c818b9e
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 12, 2025
@zakkak
Copy link
Contributor Author

zakkak commented Feb 12, 2025

Hi @JohnTortugo @bulasevich can you please review?

For more details about the process I followed see #37

@bulasevich
Copy link

Thanks for splitting the original PR into smaller, more manageable pieces. I reviewed the changes and confirmed that they are consistent with the related GR pull requests. Everything looks good to me - no objections.

Could you share how you tested the change?

@JohnTortugo
Copy link
Contributor

Thank you @zakkak . I'm going to take a look at the changes today and also trigger some internal tests.

@zakkak
Copy link
Contributor Author

zakkak commented Feb 12, 2025

Could you share how you tested the change?

Other than local builds and some trivial smoke tests, the changes are being tested using github actions, see https://github.com/graalvm/graalvm-community-jdk21u/actions (we need to update the Quarkus nightly workflow btw).

When reviewing a PR can you please indicate your approval (or request for changes) using the GitHub UI as well? You can do so by clicking on the "Files Changed" tab and then on the green button "Review Changes". Unfortunately I cannot explicitly add you as reviewers through the UI.

@zakkak zakkak added this to the 23.1.7 milestone Feb 12, 2025
@zakkak zakkak requested a review from a team February 14, 2025 10:31
jerboaa
jerboaa approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only looked at native-image and compiler parts (ignored truffle stuff). Seems OK to me.

JohnTortugo
JohnTortugo approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@JohnTortugo JohnTortugo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

I tested LibGraal JIT with OpenJDK JTREG tier1-4 and JCK using Parallel, Serial and G1GC on ARM64 and x86_64. All tests were on Amazon Linux 2. I also did some sanity check tests on GraalJS.

@zakkak zakkak merged commit daeea07 into graalvm:master Feb 17, 2025
12 checks passed
@zakkak zakkak deleted the 2025-02-12-backports-23.1.5-batch1 branch February 17, 2025 08:46
@zakkak zakkak mentioned this pull request Feb 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerboaa jerboaa jerboaa approved these changes

@JohnTortugo JohnTortugo JohnTortugo approved these changes

@bulasevich bulasevich bulasevich approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
23.1.7
Development

Successfully merging this pull request may close these issues.