Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyroscope.scrape does not allow reliably to override __profile_path__ label #2606

Open
korniltsev opened this issue Feb 4, 2025 · 0 comments
Assignees
Labels
area/pyroscope Issues/PRs primarly affecting `pyroscope.` components bug Something isn't working

Comments

@korniltsev
Copy link
Contributor

What's wrong?

The component appends a __profile_path__ label, without checking if it already exists in the target. This results in target having two labels with the same name and different values. The order of the equal labels is likely not determined because of unstable sort used later.

Related to #2597

Steps to reproduce

Have a target with __profile_path__ label as an argument.

System information

No response

Software version

c6d62ec

Configuration


Logs


@korniltsev korniltsev added the bug Something isn't working label Feb 4, 2025
@korniltsev korniltsev self-assigned this Feb 4, 2025
@simonswine simonswine added the area/pyroscope Issues/PRs primarly affecting `pyroscope.` components label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/pyroscope Issues/PRs primarly affecting `pyroscope.` components bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants