pyrosope.scrape, pyroscope.write: clarify dropped labels behavior #2629
Labels
area/pyroscope
Issues/PRs primarly affecting `pyroscope.` components
bug
Something isn't working
documentation
Improvements or additions to documentation
Milestone
pyroscope.scrape
drops all meta labels ( starts with__meta_*
)pyroscope.write
drops all private labels (starts with__
) , except__name__
and__delta__
Both dropping logic is not documented and an implementation detail.
With the new
pyroscope.relabel
component, it may be useful in some cases to NOT drop meta labels, so that they can be used inpyroscope.relabel
component.I think we should do one of the following:
pyroscope.scrape
drops meta labelspyroscope.scrape
not drop labelsMaybe we should also document
pyroscope.write
behavior as wellThe text was updated successfully, but these errors were encountered: