Skip to content

Commit

Permalink
Remove page-on-response unused parameters
Browse files Browse the repository at this point in the history
  • Loading branch information
inancgumus committed Feb 24, 2025
1 parent b4fbe8d commit 4f2acb9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions internal/js/modules/k6/browser/common/network_manager_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -215,9 +215,9 @@ func (m *EventInterceptorMock) urlTagName(_ string, _ string) (string, bool) {
return "", false
}

func (m *EventInterceptorMock) onRequest(request *Request) {}
func (m *EventInterceptorMock) onRequest(_ *Request) {}

func (m *EventInterceptorMock) onResponse(response *Response) {}
func (m *EventInterceptorMock) onResponse(_ *Response) {}

func TestNetworkManagerEmitRequestResponseMetricsTimingSkew(t *testing.T) {
t.Parallel()
Expand Down
4 changes: 2 additions & 2 deletions internal/js/modules/k6/browser/tests/page_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2477,7 +2477,7 @@ func TestPageOnResponse(t *testing.T) {
tb := newTestBrowser(t, withHTTPServer())
defer tb.Browser.Close()

tb.withHandler("/home", func(w http.ResponseWriter, r *http.Request) {
tb.withHandler("/home", func(w http.ResponseWriter, _ *http.Request) {
_, err := fmt.Fprintf(w, `<!DOCTYPE html>
<html>
<head>
Expand Down Expand Up @@ -2510,7 +2510,7 @@ func TestPageOnResponse(t *testing.T) {
_, err = fmt.Fprintf(w, `{"message": "Hello %s!"}`, data.Name)
require.NoError(t, err)
})
tb.withHandler("/style.css", func(w http.ResponseWriter, r *http.Request) {
tb.withHandler("/style.css", func(w http.ResponseWriter, _ *http.Request) {
w.Header().Set("Content-Type", "text/css")
_, err := fmt.Fprintf(w, `body { background-color: #f0f0f0; }`)
require.NoError(t, err)
Expand Down

0 comments on commit 4f2acb9

Please sign in to comment.