Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update experimental/websocket example #3724

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

mstoykov
Copy link
Contributor

What?

Update experimental/websocket example to set binaryType as to not get a warning after latest update

Why?

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov mstoykov added this to the v0.51.0 milestone Apr 29, 2024
@mstoykov mstoykov requested a review from a team as a code owner April 29, 2024 13:54
@mstoykov mstoykov requested review from oleiade and joanlopez and removed request for a team April 29, 2024 13:54
@mstoykov mstoykov merged commit cd89816 into master Apr 29, 2024
21 of 22 checks passed
@mstoykov mstoykov deleted the updateWebsocketExample branch April 29, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants