Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser: reduce races in evaluate* #4522

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

mstoykov
Copy link
Contributor

What?

Reduce the number of sobek.Runtime used in page.evaluate that are off the event loop

Why?

This is racy and very likely the underlying cause of #4085 - although without a runnable example, it is impossible to check.

Unfortunately some of the usage for evalueateHandle will require even more changes. In order to provide some fixes I opted to not try to fix everything in one go.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Possibly fixing #4085

@mstoykov mstoykov added this to the v0.57.0 milestone Feb 10, 2025
@mstoykov mstoykov requested a review from a team as a code owner February 10, 2025 10:28
@mstoykov mstoykov requested review from codebien and olegbespalov and removed request for a team February 10, 2025 10:28
@mstoykov mstoykov merged commit 0f4573f into master Feb 10, 2025
28 checks passed
@mstoykov mstoykov deleted the fixBrowserRacesInMapping branch February 10, 2025 14:31
@olegbespalov olegbespalov mentioned this pull request Feb 10, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants