browser: Fix options races p5 #4533
Conversation
codebien
changed the base branch from
master
to
codebien/fix-browser-races-2
codebien
force-pushed
the
codebien/fix-browser-races-5
branch
from
06767b8 to
520cfef
Compare
codebien
force-pushed
the
codebien/fix-browser-races-2
branch
from
ea76798 to
e92ec0e
Compare
codebien
force-pushed
the
codebien/fix-browser-races-5
branch
from
520cfef to
67e4019
Compare
codebien
requested review from
olegbespalov and
joanlopez
and removed request for
a team
| @@ -1478,16 +1474,9 @@ func (f *Frame) selectOption(selector string, values sobek.Value, opts *FrameSel | |||
| } | |||
|
|
|||
| // SetContent replaces the entire HTML document content. | |||
| func (f *Frame) SetContent(html string, opts sobek.Value) error { | |||
| func (f *Frame) SetContent(html string, _ *FrameSetContentOptions) error { | |||
There was a problem hiding this comment.
Sounds like here (and maybe upstream) we can clean up the opts completely? 🤔
There was a problem hiding this comment.
I don't know, for this reason, I would prefer if we defer this to the next release. In my opinion, it's better to coordinate with @inancgumus on similar refactors.
There was a problem hiding this comment.
@inancgumus do you have any plan in mind for it? Can we remove it or do we expect to add features where it is needed?
There was a problem hiding this comment.
It's better to keep it and add a TODO comment instead because here, we (the early-browser team) forgot to respect the options.
There was a problem hiding this comment.
@inancgumus Unfortunately, I don't have the knowledge to add a meaningful TODO. Can you add one, please? Happy to review the pull request.
What?
Continue #4524