Try to make TestConstantArrivalRateRunCorrectRate less flaky #4546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test is testing how constant arrival rate is starting iterations over time. But it used time.Sleep of 1 second which means that it doesn't actually check every second it checks and then it waits for 1 second and then again. This seems to move enough, especially on windows, that it sometimes fails. This PR uses time.Ticker to make it check every second, making it more likely that it won't drift.
mstoykov
requested review from
codebien and
olegbespalov
and removed request for
a team
olegbespalov
approved these changes
Feb 13, 2025
codebien
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The test is testing how constant arrival rate is starting iterations over time. But it used time.Sleep of 1 second which means that it doesn't actually check every second it checks and then it waits for 1 second and then again.
This seems to move enough, especially on windows, that it sometimes fails.
This PR uses time.Ticker to make it check every second, making it more likely that it won't drift.
Why?
Flaky test bad
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)