Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sobek values for mouse and keyboard #4558

Merged
merged 3 commits into from
Feb 19, 2025
Merged

Fix sobek values for mouse and keyboard #4558

merged 3 commits into from
Feb 19, 2025

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Feb 18, 2025 •
edited
Loading

What?

Fixes Sobek value usage for Mouse and Keyboard.

Why?

Fixing potential race conditions.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@inancgumus inancgumus added this to the v1.0.0-rc1 milestone Feb 18, 2025
@inancgumus inancgumus self-assigned this Feb 18, 2025
@inancgumus inancgumus force-pushed the fix/sobek-values-for-mouse-keyboard branch from f01a77f to 3a6062f Compare February 18, 2025 22:54
@inancgumus inancgumus marked this pull request as ready for review February 18, 2025 23:13
@inancgumus inancgumus requested a review from a team as a code owner February 18, 2025 23:13
@inancgumus inancgumus requested review from mstoykov and olegbespalov and removed request for a team February 18, 2025 23:13
olegbespalov
olegbespalov previously approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

mstoykov
mstoykov previously approved these changes Feb 19, 2025
View reviewed changes
@inancgumus inancgumus dismissed stale reviews from mstoykov and olegbespalov via 215f2a0 February 19, 2025 14:21
@inancgumus inancgumus force-pushed the fix/sobek-values-for-mouse-keyboard branch from 215f2a0 to 77f1fe4 Compare February 19, 2025 14:33
@inancgumus inancgumus merged commit bfc1a53 into master Feb 19, 2025
28 checks passed
@inancgumus inancgumus deleted the fix/sobek-values-for-mouse-keyboard branch February 19, 2025 15:45
@inancgumus inancgumus mentioned this pull request Feb 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstoykov mstoykov mstoykov approved these changes

@olegbespalov olegbespalov olegbespalov approved these changes

Assignees

@inancgumus inancgumus

Labels
area: browser bug
Projects
None yet
Milestone
v1.0.0-rc1
Development

Successfully merging this pull request may close these issues.
3 participants
@inancgumus @mstoykov @olegbespalov