Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser: Add page on request example #4576

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Feb 20, 2025

What?

Add page.on('request') example.

Why?

To show how to use the feature and also for E2E testing.

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the k6-documentation: grafana/k6-docs#PR-NUMBER
  • I have updated the TypeScript definitions: grafana/k6-DefinitelyTyped#PR-NUMBER
  • I have updated the release notes: link

Related PR(s)/Issue(s)

@inancgumus inancgumus added this to the v1.0.0-rc1 milestone Feb 20, 2025
@inancgumus inancgumus self-assigned this Feb 20, 2025
@inancgumus inancgumus marked this pull request as ready for review February 20, 2025 21:01
@inancgumus inancgumus requested a review from a team as a code owner February 20, 2025 21:01
@inancgumus inancgumus requested review from mstoykov and olegbespalov and removed request for a team February 20, 2025 21:01
@inancgumus inancgumus merged commit 2c5f7b2 into master Feb 24, 2025
28 checks passed
@inancgumus inancgumus deleted the add/page-on-request-example branch February 24, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants