Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stop-app in grails cli #13695

Open
codeconsole opened this issue Sep 26, 2024 · 3 comments
Open

Fix stop-app in grails cli #13695

codeconsole opened this issue Sep 26, 2024 · 3 comments

Comments

@codeconsole
Copy link
Contributor

codeconsole commented Sep 26, 2024

https://github.com/grails-profiles/base/blob/7.0.x/commands/stop-app.groovy

@codeconsole
Copy link
Contributor Author

grails-profiles/base#31

@codeconsole
Copy link
Contributor Author

management-agent.jar was removed after java 1.8 and this code should be removed/refactored

https://github.com/grails-profiles/base/blob/6294515794b8ac8ae4eeb6a3da7ff40e5f132bb8/commands/stop-app.groovy#L31

@codeconsole
Copy link
Contributor Author

codeconsole commented Sep 26, 2024

https://github.com/grails-profiles/base/blob/6294515794b8ac8ae4eeb6a3da7ff40e5f132bb8/commands/stop-app.groovy#L76-L98

Perhaps there is a better way to stop the app similar to how quit works

private void exitInteractiveMode() {
keepRunning = false
try {
GradleAsyncInvoker.POOL.shutdownNow()
} catch (Throwable e) {
// ignore
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant