Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix upload step on release workflow #955

Closed
jamesfredley opened this issue Mar 5, 2025 · 0 comments · Fixed by #958
Closed

fix upload step on release workflow #955

jamesfredley opened this issue Mar 5, 2025 · 0 comments · Fixed by #958

Comments

@jamesfredley
Copy link
Contributor

jamesfredley commented Mar 5, 2025

Disabled on: 4305974

Run Roang-zero1/github-upload-release-artifacts-action@c15e0b65ce2ae1c8d52bfbc75d017d21e1da77d7
/usr/bin/docker run --name b1869382d1f5894eaf9bfd674f3ef26808_c97d78 --label 1660b1 --workdir /github/workspace --rm -e "BETA" -e "SKIP_SNAPSHOT" -e "GIT_USER_NAME" -e "GIT_USER_EMAIL" -e "JAVA_HOME" -e "JAVA_HOME_17_X64" -e "GRADLE_ACTION_ID" -e "GRADLE_USER_HOME" -e "GRADLE_BUILD_ACTION_SETUP_COMPLETED" -e "GRADLE_BUILD_ACTION_CACHE_RESTORED" -e "DEVELOCITY_INJECTION_INIT_SCRIPT_NAME" -e "DEVELOCITY_AUTO_INJECTION_CUSTOM_VALUE" -e "DEVELOCITY_ACCESS_KEY" -e "GRADLE_ENTERPRISE_ACCESS_KEY" -e "GITHUB_DEPENDENCY_GRAPH_ENABLED" -e "GITHUB_TOKEN" -e "INPUT_ARGS" -e "INPUT_CREATED_TAG" -e "HOME" -e "GITHUB_JOB" -e "GITHUB_REF" -e "GITHUB_SHA" -e "GITHUB_REPOSITORY" -e "GITHUB_REPOSITORY_OWNER" -e "GITHUB_REPOSITORY_OWNER_ID" -e "GITHUB_RUN_ID" -e "GITHUB_RUN_NUMBER" -e "GITHUB_RETENTION_DAYS" -e "GITHUB_RUN_ATTEMPT" -e "GITHUB_REPOSITORY_ID" -e "GITHUB_ACTOR_ID" -e "GITHUB_ACTOR" -e "GITHUB_TRIGGERING_ACTOR" -e "GITHUB_WORKFLOW" -e "GITHUB_HEAD_REF" -e "GITHUB_BASE_REF" -e "GITHUB_EVENT_NAME" -e "GITHUB_SERVER_URL" -e "GITHUB_API_URL" -e "GITHUB_GRAPHQL_URL" -e "GITHUB_REF_NAME" -e "GITHUB_REF_PROTECTED" -e "GITHUB_REF_TYPE" -e "GITHUB_WORKFLOW_REF" -e "GITHUB_WORKFLOW_SHA" -e "GITHUB_WORKSPACE" -e "GITHUB_ACTION" -e "GITHUB_EVENT_PATH" -e "GITHUB_ACTION_REPOSITORY" -e "GITHUB_ACTION_REF" -e "GITHUB_PATH" -e "GITHUB_ENV" -e "GITHUB_STEP_SUMMARY" -e "GITHUB_STATE" -e "GITHUB_OUTPUT" -e "RUNNER_OS" -e "RUNNER_ARCH" -e "RUNNER_NAME" -e "RUNNER_ENVIRONMENT" -e "RUNNER_TOOL_CACHE" -e "RUNNER_TEMP" -e "RUNNER_WORKSPACE" -e "ACTIONS_RUNTIME_URL" -e "ACTIONS_RUNTIME_TOKEN" -e "ACTIONS_CACHE_URL" -e "ACTIONS_RESULTS_URL" -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/grails-doc/grails-doc":"/github/workspace" 1660b1:869382d1f5894eaf9bfd674f3ef26808 ./build/distributions/grails-docs-7.0.0-M3.zip
Verifying release
==> Create a new release
--> Uploading: grails-docs-7.0.0-M3.zip
Failed to publish release: failed to edit release: 203917621 PATCH https://api.github.com/repos/grails/grails-doc/releases/203917621: 422 Validation Failed [{Resource:Release Field:pre_receive Code:custom Message:pre_receive Sorry, branch or tag names starting with 'refs/' are not allowed.} {Resource:Release Field: Code:custom Message:Published releases must have a valid tag}]

https://github.com/grails/grails-doc/actions/runs/13681322709/job/38254182016

@jamesfredley jamesfredley added this to the grails:7.0.0-M3 milestone Mar 5, 2025
matrei added a commit that referenced this issue Mar 6, 2025
- Change `grails.version` property to `projectVersion` to be able to leverage the `post-release` action for rolling back to snapshot.
- Update release workflow to use the gh client for creating GitHub release instead of rolling our own.
- Misc. improvements.

Aiming to fix gh-955
@matrei matrei closed this as completed in 3d4deee Mar 6, 2025
@github-project-automation github-project-automation bot moved this to Done in Grails 7 Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant