Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bun related docs #1105

Closed
wants to merge 3 commits into from
Closed

feat: add bun related docs #1105

wants to merge 3 commits into from

Conversation

stonega
Copy link

@stonega stonega commented Jul 30, 2024

No description provided.

@KnorpelSenf
Copy link
Member

Bun's Node compatibility is not good enough yet, so several grammY plugins are broken and cannot be used on Bun. It would be grossly misleading to teach people to set up their project with Bun, only to tell them on several other pages that they actually should not have done this.

That being said, we are going to migrate the entire ecosystem to JSR at some point in the future. JSR currently is not mature enough for that, either, but one thing it already does well is to solve the compatibility issues. It is able to transform the plugins into a Bun-compatible version, something that our current build setups can't provide. This is being tracked in grammyjs/grammY#559.

We can get back to these changes and merge them as soon as the compatibility issues are fixed either by Bun or by us. We can keep this open for the time being.

@MasedMSD
Copy link
Collaborator

@KnorpelSenf The issue of adding Bun is becoming more and more pressing. At the moment even plugin conversation, which could throw errors before, is working more and more stable.

+1 from me for adding documentation for Bun

Btw, many users from Russian-speaking chat also actively use it.

@KnorpelSenf
Copy link
Member

@winstxnhdw can you confirm that they have fixed their support for conversations, i18n, etc?

bun add grammy
```

Create a new empty text file, e.g. called `bot.ts`.
Copy link
Collaborator

@MasedMSD MasedMSD Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't bun automatically creating index.ts if we "just press enter to accept the default answer for each prompt."

@winstxnhdw
Copy link
Member

@winstxnhdw can you confirm that they have fixed their support for conversations, i18n, etc?

Was i18n ever an issue?

@MasedMSD
Copy link
Collaborator

conversations

image

@KnorpelSenf
Copy link
Member

I think all plugins compiled with dnt were, but I have never used bun, it's only what people reported

@KnorpelSenf
Copy link
Member

So they finally fixed it? That's pretty good!

Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KnorpelSenf
Copy link
Member

Actually, that section is pretty outdated anyway. Neither the part about Node nor the part about Deno are accurate anymore. I will fix things up in a subsequent PQ. We can keep this as-is for now.

@KnorpelSenf
Copy link
Member

@KnorpelSenf
Copy link
Member

We will also have to rework all code examples at some point. This is another thing that will be done in a subsequent PQ.

@MasedMSD
Copy link
Collaborator

MasedMSD commented Oct 1, 2024

We will also have to rework all code examples at some point. This is another thing that will be done in a subsequent PQ.

It's really not that important to rewrite all the examples. There are only a few moments when Bun implements its development tools.

For example

import { spawn } from "child_process"

and

import { spawn } from "bun"

@MasedMSD
Copy link
Collaborator

MasedMSD commented Oct 1, 2024

@stonega You're still interested in continuing PR?

@rojvv
Copy link
Member

rojvv commented Nov 21, 2024

Closing due to inactivity.

@rojvv rojvv closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants