Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go 1.17 will support register based arguments instead of the stack (feature flagged) #52

Open
grantseltzer opened this issue Nov 19, 2020 · 1 comment
Open

Go 1.17 will support register based arguments instead of the stack (feature flagged) #52

grantseltzer opened this issue Nov 19, 2020 · 1 comment
Assignees
@grantseltzer
Labels
bug Something isn't working

Comments

@grantseltzer
Copy link
Owner

Will certainly still be retrievable but will need to be feature flagged. I believe the go version string is passed into the binary debug information too so could auto-detect.

golang/go#40724
@grantseltzer grantseltzer added the bug Something isn't working label Nov 19, 2020
@grantseltzer grantseltzer self-assigned this Nov 19, 2020
@grantseltzer
Copy link
Owner Author

This won't be until go 1.17 (changing title), and will be feature flagged regardless. Weaver needs to support both, can pull the Go version flag from the binary

@grantseltzer grantseltzer changed the title Go 1.16 may move arguments into registers instead of on the stack. Go 1.17 will support arguments into registers instead of on the stack. Dec 30, 2020
@grantseltzer grantseltzer changed the title Go 1.17 will support arguments into registers instead of on the stack. Go 1.17 will support register based arguments instead of the stack Dec 30, 2020
@grantseltzer grantseltzer changed the title Go 1.17 will support register based arguments instead of the stack Go 1.17 will support register based arguments instead of the stack (feature flagged) Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grantseltzer grantseltzer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@grantseltzer