Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Implemented by Inaccessible #154

Open
PascalSenn opened this issue Jan 28, 2025 · 0 comments
Open

Issues with Implemented by Inaccessible #154

PascalSenn opened this issue Jan 28, 2025 · 0 comments

Comments

@PascalSenn
Copy link
Contributor

Problem:
The algorithm for ensuring interface validity in the composite schema has multiple issues:

  1. The algorithm references execution schema concepts (e.g., @inaccessible) that are not applicable to the composite schema.
  2. The logic assumes that some types/fields are not visible in the merged (composite) schema, which contradicts the nature of the composite schema where everything is visible.
  3. The current rule does not correctly handle cases where interfaces implement other interfaces, requiring the implementation of all fields.

Proposed Solution:

  • Update the algorithm to align with the composite schema context, removing references to execution schema-specific elements like @inaccessible.
  • Ensure that the rule validates interface implementation correctly for interfaces that implement other interfaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant