-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First draft for upgrade guide to v17 #4310
Conversation
Hi @JoviDeCroock, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
@JoviDeCroock I have started working on merging in what I have been tracking in #4198 ... these are a few suggestions so far, let me know if you'd rather have me open up PRs to this PR rather than do it like this. |
6652fda
to
1c1fa22
Compare
1c1fa22
to
0301509
Compare
0301509
to
edf1802
Compare
edf1802
to
0b835b3
Compare
0b835b3
to
b1d1e2d
Compare
Co-authored-by: Yaacov Rydzinski <[email protected]>
b1f64bc
to
6d49a35
Compare
6d49a35
to
baa39f1
Compare
Closed #4198, added the remainder of items from that PR as review comments. Let me know if you would just prefer a PR into this PR. |
Co-Authored-By: yaacovcr <[email protected]>
that you are working with externally provided values i.e. the SDL provided defaultValue to a variable. | ||
- Deprecated `valueFromAST` use `coerceInputLiteral` instead | ||
- Deprecated `findBreakingChanges()` and `findDangerousChanges()`. Use `findSchemaChanges()` instead, which can also be used to find safe changes. | ||
- Deprecated `serialize`. `parseValue`, and `parseLiteral` properties on scalar type configuration. Use `coerceOutputValue`, `coerceInputValue`, and `coerceInputLiteral` instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this simply a rename or is more work required?
|
||
- Added `hideSuggestions` option to `execute`/`validate`/`subscribe`/... to hide schema-suggestions in error messages | ||
- Added `abortSignal` option to `graphql()`, `execute()`, and `subscribe()` allows cancellation of these methods; | ||
the `abortSignal` can also be passed to field resolvers to cancel asynchronous work that they initiate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“Can also be” - how? Should this be “is also”? Also, is it via resolveinfo?
No description provided.