Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft for upgrade guide to v17 #4310

Merged
merged 4 commits into from
Feb 19, 2025
Merged

First draft for upgrade guide to v17 #4310

merged 4 commits into from
Feb 19, 2025

Conversation

JoviDeCroock
Copy link
Member

No description provided.

Copy link

Hi @JoviDeCroock, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR
Copy link
Contributor

@JoviDeCroock I have started working on merging in what I have been tracking in #4198 ... these are a few suggestions so far, let me know if you'd rather have me open up PRs to this PR rather than do it like this.

@yaacovCR
Copy link
Contributor

@JoviDeCroock I have started working on merging in what I have been tracking in #4198 ... these are a few suggestions so far, let me know if you'd rather have me open up PRs to this PR rather than do it like this.

Closed #4198, added the remainder of items from that PR as review comments. Let me know if you would just prefer a PR into this PR.

Co-Authored-By: yaacovcr <[email protected]>
@JoviDeCroock JoviDeCroock merged commit 7066b58 into 16.x.x Feb 19, 2025
31 checks passed
that you are working with externally provided values i.e. the SDL provided defaultValue to a variable.
- Deprecated `valueFromAST` use `coerceInputLiteral` instead
- Deprecated `findBreakingChanges()` and `findDangerousChanges()`. Use `findSchemaChanges()` instead, which can also be used to find safe changes.
- Deprecated `serialize`. `parseValue`, and `parseLiteral` properties on scalar type configuration. Use `coerceOutputValue`, `coerceInputValue`, and `coerceInputLiteral` instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this simply a rename or is more work required?


- Added `hideSuggestions` option to `execute`/`validate`/`subscribe`/... to hide schema-suggestions in error messages
- Added `abortSignal` option to `graphql()`, `execute()`, and `subscribe()` allows cancellation of these methods;
the `abortSignal` can also be passed to field resolvers to cancel asynchronous work that they initiate.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“Can also be” - how? Should this be “is also”? Also, is it via resolveinfo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants