Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support different classNames for assigning annotations to Ingresses (or drop the magic) #25

Open
gw0 opened this issue Jan 24, 2023 · 0 comments

Comments

@gw0
Copy link
Contributor

gw0 commented Jan 24, 2023

Currently, the className setting for Ingress contains magic to add annotations if it equals nginx, public, and traefic. The design is misleading, because one can install e.g. multiple nginx-ingress controllers each one under a different name. One would expect that annotations under .Values.ingress.annotations.nginx will be used for all of them.

Also noticed, that the MQ Ingress is missing base annotations.

@gw0 gw0 changed the title Support different classNames for Ingress Support different classNames for assigning annotations to Ingresses (or drop the magic) Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant