Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewing database columns #5056

Open
dch0ph opened this issue Jan 19, 2025 · 0 comments
Open

Reviewing database columns #5056

dch0ph opened this issue Jan 19, 2025 · 0 comments

Comments

@dch0ph
Copy link
Contributor

dch0ph commented Jan 19, 2025

As a task from #5027, we should review the database columns.

I don't know an objective way to do this; it would require some skill and a lot of work to quantitatively assess effects on database performance. But here are some quick thoughts:

  • We have previously considered whether foot, bicycle and horse should be relegated to hstore. Although used frequently (e.g. foot 9.9m), they are not important for "primary selection" and only really used in conjunction with other access tags, such as motor_vehicle which are in hstore. Having all the mode-specific tags in hstore would allow us to simplify the arguments to carto_highway_int_access and only pull out the access tags as required for a specific highway type.
  • lock (14.7k) seems a prime candidate for relegation. Not even used in the selection for water-lines-text.
  • route (1.2m) only seems to be used for ferry routes.
  • military (181k) and aerialway (206k), despite being top-level tags hardly seem to justify their own columns, but are used in multiple queries. Leave as is?
  • religion (1.8m) is not used in selection. There doesn't seem a reason for this to have its own column when other tags, such as sport (2.8m) and location (3.2m) are pulled from hstore in the amenity query.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant