Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PiHole Kit: Adding multiple Pi-Hole instances causes error #160

Open
ShaunNeutron opened this issue Jan 20, 2024 · 1 comment
Open

PiHole Kit: Adding multiple Pi-Hole instances causes error #160

ShaunNeutron opened this issue Jan 20, 2024 · 1 comment
Assignees
Labels
02 - Medium medium priority

Comments

@ShaunNeutron
Copy link

I run two pihole instances at my house. One is user focused and the other is IOT focused. Based on the installation/setup instructions for the pihole kit, it says that you can separate multiple values by using a comma, which in my mind implies that you can query data from multiple instances. When I define two comma separated IPs and two comma separated API keys, I get the following error:

Scheduled script PiHole Script (374133653) failed at Jan 20 03:50:00: unexpected continue statement

Does the kit support multiple and there is something wrong or does it only support a single instance and the installation tips need to be updated?

@ashnwade ashnwade added the 02 - Medium medium priority label Jan 22, 2024
@ashnwade ashnwade added this to the v5.4.5 milestone Jan 22, 2024
@ashnwade ashnwade modified the milestones: v5.4.5, v5.4.6 Feb 5, 2024
@mike-wade-gravwell
Copy link
Contributor

It does not support multiple PiHole instances at the moment. It would probably work if we changed the input for the host and port to a resource but that opens up the possibility for adding to many for the script to handle. I may need to cap it to 3 or 5 instances so the script doesn't get overloaded.

@ashnwade ashnwade modified the milestones: v5.4.6, v5.4.7 Mar 5, 2024
@kris-watts-gravwell kris-watts-gravwell modified the milestones: v5.4.7, v6.0.0 Mar 18, 2024
@ashnwade ashnwade removed this from the v6.0.0 milestone May 30, 2024
@ashnwade ashnwade removed the bug label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02 - Medium medium priority
Projects
None yet
Development

No branches or pull requests

4 participants