From 0fdd84263b006b49a4b5d2ade02d5164d0caabd9 Mon Sep 17 00:00:00 2001
From: Matt Mundell <matt@mundell.me>
Date: Mon, 13 May 2024 17:33:08 +0200
Subject: [PATCH] Fix: missing return in handle_get_credentials

---
 src/gmp.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/src/gmp.c b/src/gmp.c
index 417a12e65..ec56ecdaa 100644
--- a/src/gmp.c
+++ b/src/gmp.c
@@ -12201,10 +12201,15 @@ handle_get_credentials (gmp_parser_t *gmp_parser, GError **error)
     format = CREDENTIAL_FORMAT_NONE;
 
   if (format == CREDENTIAL_FORMAT_ERROR)
-    SEND_TO_CLIENT_OR_FAIL
-      (XML_ERROR_SYNTAX ("get_credentials",
-                         "Format attribute should"
-                         " be 'key', 'rpm', 'deb', 'exe' or 'pem'"));
+    {
+      SEND_TO_CLIENT_OR_FAIL
+        (XML_ERROR_SYNTAX ("get_credentials",
+                           "Format attribute should"
+                           " be 'key', 'rpm', 'deb', 'exe' or 'pem'"));
+      get_credentials_data_reset (get_credentials_data);
+      set_client_state (CLIENT_AUTHENTIC);
+      return;
+    }
 
   INIT_GET (credential, Credential);